search

scoutapp / scout-apm-laravel

ScoutAPM PHP Agent for the Laravel Framework
MIT License
22 stars 12 forks source link

Configuration conflict with Laravel's Scout #37

Closed asgrim closed 4 years ago

asgrim commented 4 years ago

As per comment:

scout apm using the name scout.php for configs conflicts with the config file of the first party package Laravel/scout https://github.com/laravel/scout

We can rename the config (and thus, the key used) to scoutapm but I'm not sure we can do this in a BC way. Need to check.

dlanderson commented 4 years ago

For consistency I'd suggest scout_apm.php - we use scout_apm.yml in Ruby.

cschneid commented 4 years ago

I don't think we worry about BC on this change. It's unlikely anybody has installed the agent since we released it, and used the config file. And the agent should fall back politely onto our suggested ENV configs, without raising exceptions.

We have support@scoutapm.com to help anybody who needs help renaming.

asgrim commented 4 years ago

OK; I'll make sure to note it in the CHANGELOG.md

asgrim commented 4 years ago

Conflict is fixed in 1.2.0 (cc @imhmdb)