scoutapp / scout-apm-laravel

ScoutAPM PHP Agent for the Laravel Framework
MIT License
22 stars 12 forks source link

Test against custom blade directives #45

Closed cschneid closed 4 years ago

cschneid commented 4 years ago

We had a report of an issue with a custom blade directive.

I did notice that installing your Laravel package broke a custom Blade directive
that we use from the spatie/laravel-permission package.
What’s the best way to troubleshoot this?
For now, I was able to refactor usage of that `@role` directive,
but I’d like to get that fixed and understand why it broke.

I'm asking for any exception or backtrace, but this is worth looking into.

cschneid commented 4 years ago

I believe the blade ext is this: https://github.com/spatie/laravel-permission/blob/master/src/PermissionServiceProvider.php#L67-L72

cschneid commented 4 years ago

From the customer:

"No error was caused by the Blade directive, it just rendered the Blade code as text, which broke some conditional logic on the page."

asgrim commented 4 years ago

Fixed in 1.2.3 :+1:

joelclermont commented 4 years ago

Thank you!!! Such speedy support! I ran into an issue (unrelated, Composer issue) and blogged about it https://joelclermont.com/post/things-to-know-when-updating-a-single-composer-package/

asgrim commented 4 years ago

@joelclermont you are most welcome :) Nice post, and good to know! Thanks