scoutapp / scout_apm_elixir

ScoutAPM Elixir Agent. Supports Phoenix and other frameworks.
https://scoutapm.com
Other
36 stars 20 forks source link

Boolean config params doesn't work when set using ENVs #126

Open kapone89 opened 1 year ago

kapone89 commented 1 year ago

Boolean config params set using ENVs, like

SCOUT_CORE_AGENT_DOWNLOAD=false
SCOUT_CORE_AGENT_LAUNCH=false

Doesn't work, because they are parsed as strings. So e.g. here https://github.com/scoutapp/scout_apm_elixir/blob/master/lib/scout_apm/core/agent_manager.ex#L53 There will be "false" string and !!"false" is true