search

scoutapp / scout_apm_elixir

ScoutAPM Elixir Agent. Supports Phoenix and other frameworks.
https://scoutapm.com
Other
36 stars 20 forks source link

Add support for instrumenting Slime templates #54

Closed jeffjewiss closed 6 years ago

jeffjewiss commented 6 years ago

Hi there, I was looking to setup elixir_plug_server_timing in my app, however I'm using Slime for most of my templates. I tested this locally and was able to see timings for Slime templates in Chrome when adding this additional instrument.

I tried to follow the existing setup and style, but please let me know if you'd like to see anything changed as I'm still new to Elixir.

Cheers.

cschneid commented 6 years ago

Thank you for the contribution! We'll take a look at it soon, but it looks pretty straight forward.

jeffjewiss commented 6 years ago

Thanks! I just wanted to follow up on this and see if there was anything I could do to help get this accepted. Cheers!

itsderek23 commented 6 years ago

@mitchellhenke - Mind giving this a look, and if OK, merging and doing a release? Thanks!

/cc @jeffjewiss

mitchellhenke commented 6 years ago

@itsderek23 yep, can do!

mitchellhenke commented 6 years ago

@itsderek23 Pulled down the branch and looks like everything works as expected!

image

itsderek23 commented 6 years ago

🍾 Great!

Mind doing a new release and /cc-ing @jeffjewiss on this issue when it's cut? Thanks!

mitchellhenke commented 6 years ago

@jeffjewiss I've released 0.4.2 and pushed it to hex 🙂

jeffjewiss commented 6 years ago

Thanks for the quick turn-around on this, appreciate it!