search

scoutapp / scout_apm_elixir

ScoutAPM Elixir Agent. Supports Phoenix and other frameworks.
https://scoutapm.com
Other
36 stars 20 forks source link

Don't report if an API key isn't provided #6

Closed itsderek23 closed 7 years ago

itsderek23 commented 7 years ago

We currently report data if an API key isn't provided:

07:45:08.669 application=scout_apm [info] Reporting ScoutAPM Payload to http://localhost:3000/apps/checkin.scout?key=&name=HeroReview
07:45:08.917 application=scout_apm [info] Reporting ScoutAPM Payload Succeeded. Status: 200

With Devtrace #4 coming, folks can use the scout_apm package w/o an API key. We should log if a key isn't configured and prevent reporting.

itsderek23 commented 7 years ago

Related: we should have a monitor key that enables/disables monitoring.

Our provided config/scout_apm.exs file should set this true.

If monitor != true || NO KEY, don't report.

On startup, would be nice to log the state of this.