search

scoutapp / scout_apm_elixir

ScoutAPM Elixir Agent. Supports Phoenix and other frameworks.
https://scoutapm.com
Other
36 stars 20 forks source link

upgrade telemetry #74

Closed mitchellhenke closed 5 years ago

mitchellhenke commented 5 years ago

ecto_sql bumped the version of telemetry that included some breaking changes:

https://github.com/elixir-ecto/ecto_sql/blob/master/CHANGELOG.md#enhancements-2 https://github.com/beam-telemetry/telemetry/blob/master/CHANGELOG.md#030

There's also a 0.4.0 out, but doesn't look like Ecto has a release that includes it (yet)

jaimeiniesta commented 5 years ago

I get this warning after this PR was merged:

warning: function :telemetry.attach/4 is undefined (module :telemetry is not available)
  lib/scout_apm/instruments/ecto_telemetry.ex:17
mitchellhenke commented 5 years ago

@jaimeiniesta you see that warning while running with telemetry version 0.3.0?

jaimeiniesta commented 5 years ago

@mitchellhenke nope, that was with telemetry 0.2.0. I've just upgraded it to 0.3.0 and now the warning is gone, thanks!