search

scoutforpets / ember-fullcalendar

An Ember Component for FullCalendar and FullCalendar Scheduler
MIT License
39 stars 45 forks source link

Fullcalendar-scheduler v1.4.0 causes a dependency conflict #27

Closed mtudor closed 8 years ago

mtudor commented 8 years ago

From version 1.4.0, fullcalendar-scheduler specifies fullcalendar version >=3.0.0 as a dependency. This causes a conflict as this module states fullcalendar version ^2.7.3, which can't be satisfied by version 3.0.0. This has been resolved by changing the dependency on fullcalendar-scheduler to ~1.3.3 instead of ^1.3.3, to stop version 1.4.0 being installed.

mtudor commented 8 years ago

This may be irrelevant if #26 gets merged. You might, however, want to merge this (#27) to fix the fullcalendar v2 as a patch release before upping to a new major version of your addon to merge #26 which the contributor has highlighted as breaking. So with that in mind, I'll leave this here ;)

It's also dead small so probably could be merged slightly more easily than #26.

jamesdixon commented 8 years ago

@mtudor per your suggestion, released this as 0.5.1. Thanks for your help!

mtudor commented 8 years ago

Great stuff James, and thanks for the rapid merge. I can confirm that the patch installed with no dependency conflicts on my end so that's fantastic - thanks!