Closed mcfiredrill closed 7 years ago
@mcfiredrill thanks for the breakdown of the true/false logic...lol
I missed it during the review of the PR that added this functionality, but yes, I'd agree that it would be better to explicitly set it.
Thanks for fixing this.
Cheers
enabled: this.includeScheduler || true
doesn't seem right to me, won't this always return true even ifincludeScheduler
is undefined, null or false?It seems safer to explicitly set it to true.