search

scoutforpets / ember-fullcalendar

An Ember Component for FullCalendar and FullCalendar Scheduler
MIT License
39 stars 45 forks source link

Include locale-all.js in dist #42

Closed lionelrudaz closed 7 years ago

lionelrudaz commented 7 years ago

Add locales-all.js in index.js to support locale option of the component

jamesdixon commented 7 years ago

@lionelrudaz thanks for this!

In the interest of keeping the asset size to a minimum, would you mind adjusting this to make inclusion of locales-all.js optional? I believe you can use a function to dynamically configure included assets: see https://github.com/dfreeman/ember-cli-node-assets.

jamesdixon commented 7 years ago

@lionelrudaz any thoughts on this?

lionelrudaz commented 7 years ago

@jamesdixon sorry for my late reply. My job is keeping me busy and I didn't have time for that.

I close the PR. I think #51 is better than my solution. Looking forward to seeing it merged.

Let me know if there's anything I can do to help.