search

scoutforpets / ember-fullcalendar

An Ember Component for FullCalendar and FullCalendar Scheduler
MIT License
39 stars 45 forks source link

Add info do README.md that you need to install ember-moment #55

Closed markwatney2016 closed 6 years ago

markwatney2016 commented 7 years ago

This solves https://github.com/scoutforpets/ember-fullcalendar/issues/54

jamesdixon commented 7 years ago

@markwatney2016 thanks for submitting. I thought this was taken care of, but evidently not!

I double checked and moment is actually installed with fullcalendar. That said, I was playing around with things a bit and ember-moment doesn't need to be installed. I believe the issue was that ember-cli-moment-shim was part of devDependencies rather than dependencies (it needs to be part of the consuming application).

jamesdixon commented 7 years ago

@markwatney2016 can you try installing from #56 and see if it resolves the issue for you? it appears to work in my local testing

jamesdixon commented 6 years ago

should be fixed with #67. feel free to re-open if you're still having problems