search

scoutforpets / jsonapi-mapper

JSON API-Compliant Serialization for your Node ORM
The Unlicense
42 stars 24 forks source link

TypeORM Integration #106

Open johannesschobel opened 5 years ago

johannesschobel commented 5 years ago

Dear team,

I would like to evaluate if it is possible to use this package in combination with TypeORM instead of Bookshelf. Or rather pass any object (or object[]) to this package in order to serialize the data accoring to the JSON:API styleguide..

What do you think? Do we need a TypeORM integration or would it be better to get the data in a separate package and only pass the object or object[] to the package here?

All the best

chamini2 commented 5 years ago

I think I see your point with the idea of passing in a single type of object or object[] and do the ORM to JSON transformation in another. It can be interesting to pursue this option.

The thing is that we have a lot of options available and a lot of functionality. You can go ahead and send a PR our way to change how it's done. If the tests pass and the code looks good, it will surely get merged!