search

scoutforpets / jsonapi-mapper

JSON API-Compliant Serialization for your Node ORM
The Unlicense
42 stars 24 forks source link

stringifying json with circular dependencies #55

Closed jamesdixon closed 8 years ago

jamesdixon commented 8 years ago

I ran into an issue where data I received from an external API contained circular references, which throws an error when stringifying. Normally, this could be resolved by using something like fast-safe-stringify, but given that we have our own method of converting to JSON, this may be not be an option. I haven't investigated in any depth, but wanted to bring it up.

jamesdixon commented 8 years ago

@chamini2 in regards to your comment in #47, you're correct. In most cases, I think this probably isn't going to be an issue. We'll mark it as an enhancement/help-wanted.

chamini2 commented 8 years ago

@jamesdixon, can we close this one? I don't think this is or will be a problem.

jamesdixon commented 8 years ago

@chamini2 agreed!