search

scoverage / gradle-scoverage

A plugin to enable the use of Scoverage in a gradle Scala project
Apache License 2.0
53 stars 38 forks source link

Add support for Scala 2.13 #110

Closed eyalroth closed 5 years ago

eyalroth commented 5 years ago

Fixes #106. Fixes #109.

Still depends on upgrading the plugin to support version 1.4.0 of the scalac plugin, as there is no other version available for Scala 2.13. See #107.

Also removes a functional test for multi-language support, which I believe was added following #102, but is unnecessary as there is already a functional test for that.

maiflai commented 5 years ago

support for 2.13 now on master?

eyalroth commented 5 years ago

@maiflai Did you manually added these changes as commits on master or as part of the 1.4 PR?

I'm not seeing the changes of commit https://github.com/scoverage/gradle-scoverage/pull/110/commits/64ad30efbe4d99e2624c64ee6ed56bfcf077fbc4 from this PR (the deletion of a redundant functional test).

We should also close #106 and #109 (I don't have the permissions).

maiflai commented 5 years ago

sorry, yes - merged locally and I must have missed the removal of the functional test.

I tend to close the issues after a release and confirmation that they are really closed. I didn't have time to watch the build earlier today, I'll take a closer look at the failure.

thanks very much for all your work on this, it's much appreciated.