search

scoverage / gradle-scoverage

A plugin to enable the use of Scoverage in a gradle Scala project
Apache License 2.0
53 stars 38 forks source link

(#125) fix compatibility with scala 2.11 #126

Closed pan3793 closed 4 years ago

pan3793 commented 4 years ago

Fixes https://github.com/scoverage/gradle-scoverage/issues/125

eyalroth commented 4 years ago

Thank you for this fix. Looks like the cross-version test was broken (addressed in #127).

Could you edit the description to "Fixes #125"? It will make sure the ticket is closed once the PR is merged.

pan3793 commented 4 years ago

@eyalroth Thanks for your guidance, description has been changed.

maiflai commented 4 years ago

Thanks both.

Please can I confirm something though? I expected that merging @eyalroth's test change would break master, but it doesn't.

Is there still a missing test case?

I should have fixed this upstream as part of the 1.4.1 change, but I missed the opportunity.

Stu.

eyalroth commented 4 years ago

@maiflai I also expected my PR to not pass the checks. The changed test does fail on my machine, both when running from windows and linux (WSL), with either Oracle's JDK or OpenJDK.

Perhaps the check passes because it doesn't clean the project?

$ ./gradlew assemble
$ ./gradlew --info --stacktrace check
eyalroth commented 4 years ago

@maiflai Hmm I think the problem is actually that other functional tests are running before the cross-version test in the same JVM. I tried to remedy that in #128 by running the cross-version test before all the other functional tests. If my theory is correct, then #128 should now fail the check.

Edit: It fails, hooray!