search

scoverage / gradle-scoverage

A plugin to enable the use of Scoverage in a gradle Scala project
Apache License 2.0
53 stars 38 forks source link

Do not fail on missing scoverage compile task in dependency #137

Closed JozoVilcek closed 4 years ago

JozoVilcek commented 4 years ago

Fix for https://github.com/scoverage/gradle-scoverage/issues/136

eyalroth commented 4 years ago

Looks good, thank you for the contribution!

Could you add a new functional test which replicates the bug? Take a look at the functionalTest directory for reference. Also, I believe that this particular test case only needs a "dry run", since it tests the configuration and not the actual execution of the plugin.

JozoVilcek commented 4 years ago

@eyalroth I can try. Do you prefer to edit one of existing projects (which one?) or create a new one specifically for this purpose?

eyalroth commented 4 years ago

I think a new project is preferable; otherwise, this will make the other existing projects more complex than they should be.

JozoVilcek commented 4 years ago

@eyalroth can you take a loot at change and suggest further changes to the tests if needed? Thanks

eyalroth commented 4 years ago

@JozoVilcek Oh I wasn't notified on your force-push. The test looks good, as long as it fails without the fix :)

FYI I don't have write permissions so I can't merge this. @maiflai

JozoVilcek commented 4 years ago

@maiflai do you have time to look at this PR?