search

scoverage / gradle-scoverage

A plugin to enable the use of Scoverage in a gradle Scala project
Apache License 2.0
53 stars 38 forks source link

Make the plugin compatible with Palantir's consistent versions plugin #143

Closed eyalroth closed 4 years ago

eyalroth commented 4 years ago

Fixes #140.

This PR introduces a small change in behavior. The Scala version of the scoverage dependencies will now only be automatically detected if the scoverageScalaVersion is not defined. Previously, it overrided that option regardless if it was defined or not.

Note the changes to the README.md file explaining how to make a build compatible with the Palantir plugin (need to manually configure the Scala version via scoverageScalaVersion).

nyonson commented 4 years ago

Any chance we could get this merged?

eyalroth commented 4 years ago

@maiflai care to take a look? :)

maiflai commented 4 years ago

thanks both - there seems to be recent activity upstream, is it ok to wait for a little bit to see if a release is coming out there?

nyonson commented 4 years ago

What's the timeline for that? I work on a large monorepo which would greatly benefit from the performance improvements that this change would provide, so would vote for a release sooner rather than later.