search

scoverage / gradle-scoverage

A plugin to enable the use of Scoverage in a gradle Scala project
Apache License 2.0
53 stars 36 forks source link

Migrate to Kotlin DSL #172

Open eyalroth opened 3 years ago

eyalroth commented 3 years ago

Implements #171.

CristianGM commented 2 years ago

You have mixed too many changes (and reasons to change) in a single PR. I don't feel like reviewing so much lines looking for the important changes.

I would suggest splitting it, at least in the 3 things I've seen so far: Gradle -> gradle.kts Using kotlin property syntax instead of getters Convert a java file to kt

Other than that I left a couple of comments.

Feel free to ping me if you want review in smaller PRs.