search

scoverage / sbt-coveralls

sbt-plugin to upload sbt-scoverage reports to coveralls
https://github.com/scoverage
Other
104 stars 50 forks source link

Publish sbt-coveralls plugin with JDK 8? #250

Closed mdedetrich closed 1 year ago

mdedetrich commented 1 year ago

I am getting

java.lang.UnsupportedClassVersionError: org/eclipse/jgit/storage/file/FileRepositoryBuilder has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

From https://github.com/mdedetrich/akka-streams-json/actions/runs/4440234230/jobs/7793780169?pr=86.

This is usually caused when you release sbt-plugin with a newer JDK. Would it be possible to release this plugin with JDK 8?

rolandtritsch commented 1 year ago

Merged. Published. Released. Thanks for the contribution. - https://github.com/scoverage/sbt-coveralls/releases/tag/v1.3.7

ruippeixotog commented 1 year ago

From https://github.com/pureconfig/pureconfig/pull/1484, I believe something went wrong... it looks like sbt-coveralls v1.3.7 still depends on JDK 11 (https://github.com/pureconfig/pureconfig/actions/runs/4584898251/jobs/8096681785?pr=1484).

mdedetrich commented 1 year ago

@ruippeixotog Created a PR at https://github.com/scoverage/sbt-coveralls/pull/252 to resolve the problem.

ruippeixotog commented 1 year ago

@mdedetrich, is there a chance you can release a new version of sbt-coveralls with https://github.com/scoverage/sbt-coveralls/pull/252 so we can update sbt-coveralls on JDK 8 projects? Thanks!

mdedetrich commented 1 year ago

I am not a maintainer so I can't make a release, I would presume @rolandtritsch would have the ability to make a release since he merged my fixes.

rolandtritsch commented 1 year ago

Hi All. This week I am at ElixirConfEU in Lisbon/Portugal. Will cut a new release on Fri or Sat, if that is ok. - RT

On Sun, Apr 16, 2023 at 11:42 PM Matthew de Detrich < @.***> wrote:

I am not a maintainer so I can't make a release, I would presume @rolandtritsch https://github.com/rolandtritsch would have the ability to make a release since he merged my fixes.

— Reply to this email directly, view it on GitHub https://github.com/scoverage/sbt-coveralls/issues/250#issuecomment-1510507664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFD5FL4TH3XEA35IANLVSDXBRYUXANCNFSM6AAAAAAV6IKOJI . You are receiving this because you were mentioned.Message ID: @.***>

rolandtritsch commented 1 year ago

Hi All. This week I am at ElixirConfEU in Lisbon/Portugal. Will cut a new release on Fri or Sat, if that is ok. - RT

Done.