search

scoverage / sbt-coveralls

sbt-plugin to upload sbt-scoverage reports to coveralls
https://github.com/scoverage
Other
104 stars 50 forks source link

Use JDK 8 for release #252

Closed mdedetrich closed 1 year ago

mdedetrich commented 1 year ago

Not sure why the -release:8 scalac flag didn't work when releasing a new version but one way to enforce JDK 8 compatibility is to just use JDK8 when releasing.

Also since we are building against JDK 8, I added it to the normal CI to make sure we don't break JDK 8 compatiblity

mdedetrich commented 1 year ago

@ruippeixotog So if you look at the CI run in this PR against JDK 8 I think I figured out the issue, it appears that the problem is in a dependency , i.e. org/eclipse/jgit/storage/file/FileRepositoryBuilder. This has been solved in a separate PR made at https://github.com/scoverage/sbt-coveralls/pull/253.

This means that the -release:8 argument technically speaking is working because its making sure that this project emits JDK 8 compatible bytecode but of course it cannot magically convert the dependencies of this project to also target JDK 8.

ruippeixotog commented 1 year ago

Thanks for the quick fix, @mdedetrich! Agree that the best way to guarantee it works with JDK 8 (including dependencies) is to have CI use it.

rolandtritsch commented 1 year ago

Also since we are building against JDK 8, I added it to the normal CI to make sure we don't break JDK 8 compatiblity

Agreed. Merged. Thanks for the fix.