search

scoverage / scalac-scoverage-plugin

Scoverage Scala Code Coverage Core Libs
https://github.com/scoverage
Apache License 2.0
425 stars 126 forks source link

Generated html reports can't be loaded properly because of CSP #173

Open amalinko opened 8 years ago

amalinko commented 8 years ago

First of all, thank you guys for great plugin. But we have a problem. I'm not sure if it could be changed or it is absolutely by design. We've updated our Jenkins and new version uses CSP. And Scoverage generates HTML with external sources. For example: https://github.com/scoverage/scalac-scoverage-plugin/blob/master/scalac-scoverage-plugin/src/main/resources/scoverage/index.html It has <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/pure/0.3.0/pure-min.css"> in it. So this style can't be loaded, because it is external resource. While CSP in Jenkins could be configured, it's not very convenient because either we have to find all sources Scoverage uses or to switch the policy off completely. Is it possible to make Scoverage reports CSP compatible?

gslowikowski commented 8 years ago

See my comment (and other comments as well).

xohzzwn6kcj9 commented 7 years ago

any updates on this?

Johnlon commented 6 years ago

+1. Long time, no fix

ALPSMAC commented 6 years ago

Just adding to the list of folks who would like to see a fix for this. The Jenkins instance we use can not just open up CSP to a full CDN.

etspaceman commented 6 years ago

+1

ziggystar commented 6 years ago

Maybe it would be a start if someone finds out how this can be fixed? Is it only about this stylesheet? Can't we simply include it with the report? Maybe make it an setting to include the css file, or not.

The ability to view a coverage report on a CI server is a very basic requirement.