search

scoverage / scalac-scoverage-plugin

Scoverage Scala Code Coverage Core Libs
https://github.com/scoverage
Apache License 2.0
425 stars 126 forks source link

add JDK 17 to CI #394

Closed SethTisue closed 3 years ago

SethTisue commented 3 years ago

I looked at a subset of the failures and in that subset anyway, InvokerConcurrencyTest was always the failure. Is that known to be a flaky test?

I wasn't able to reproduce it failing locally on e.g. 2.13.6 / JDK 17.

ckipp01 commented 3 years ago

I looked at a subset of the failures and in that subset anyway, InvokerConcurrencyTest was always the failure. Is that known to be a flaky test?

yea on windows this often times out. It's actually fixed on the V2 branch. Thanks for sending this in btw. I'll probably carry this over and merge it into the V2 branch as I'm hoping to get a 2.0.0-RC1 release someone quickly that will change a lot of stuff mainly to unlock the support for Scala 3. It has a smaller build matrix since 89 is a bit insane imo. I'll make sure to get this included in there.

SethTisue commented 3 years ago

fwiw, I think you could simply drop some of the more antiquated Scala versions, though I don't know where exactly to draw the line

SethTisue commented 3 years ago

I'll make sure to get this included in there

okay, closing then.

ckipp01 commented 3 years ago

okay, closing then.

👍🏼 sounds good. Sorry, haven't gotten around to addressing this yet. I plan on working on scoverage stuff later this week, so you'll see this pop up again then.