search

scoverage / scalac-scoverage-plugin

Scoverage Scala Code Coverage Core Libs
https://github.com/scoverage
Apache License 2.0
425 stars 126 forks source link

Add support for JSDOM JSEnv #456

Closed armanbilge closed 2 years ago

armanbilge commented 2 years ago

Relates to https://github.com/scoverage/scalac-scoverage-plugin/issues/183 and https://github.com/scoverage/scalac-scoverage-plugin/pull/212.

Specifically https://github.com/scoverage/scalac-scoverage-plugin/pull/212 suggests

There should be also a corresponding change applied for JSDOMNodeJSEnv class in scala-js/scalajs-bundler to export global object, either by extending it with a setting to do so, or by creating separate implementation

This PR works around that, so no changes are needed upstream. /cc @viktor-podzigun

ckipp01 commented 2 years ago

Thanks a lot for the pr @armanbilge. Can you target the V2 branch, as all new development is going to be taking place there now since there will be no more stable releases until 2.x is released. I'll try to look at this a bit closer in the coming days as I'm extremely unfamiliar with this, and a bit iffy if we're not actually testing it at all in CI.

armanbilge commented 2 years ago

Thanks for the response, can do!

and a bit iffy if we're not actually testing it at all in CI.

Ok, I won't be so lazy then and I'll actually add it to CI 😅 sorry!

armanbilge commented 2 years ago

Thanks for the fast review! :)

viktor-podzigun commented 2 years ago

Nice 🎉 Thank you!