Without Post Processing fog in nebula is broken since #1846.

scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open

https://www.hard-light.net/

Other

400 stars 161 forks source link

Without Post Processing fog in nebula is broken since #1846. #2227

Open tomimaki opened 4 years ago

tomimaki commented 4 years ago

As is visible in topic below, objects far away from player are not covered by fog when post_process is off. https://www.hard-light.net/forums/index.php?topic=96182.msg1891537#msg1891537 Before #1846 screen0469 After #1846 screen0470 Checked on Nvidia 1050 (441.66 drivers) and Intel (drivers from 2019-11-06)

Baezon commented 2 years ago

For posterity, I'll mention that this is caused by the srgb_to_linear conversion here https://github.com/scp-fs2open/fs2open.github.com/blob/master/code/def_files/data/effects/fog-f.sdr#L35. Without post processing, and that conversion removed it fogs to the correct color again. I've bought up only conditionally doing this step, but the other graphics coders seemed to prefer deprecating -no_post_proc entirely instead.

JohnAFernandez commented 2 years ago

Should probably stick a won't fix on this.

MjnMixael commented 5 months ago

Just checking in. If this is not going to be fixed then, given how critical the Nebula environment is to FS2 and many mods, the commandline flag should be deprecated and the Post Processing option should be removed.