search

scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open
https://www.hard-light.net/
Other
406 stars 162 forks source link

Submodel-destroyed visible all time in some models #3078

Closed tomimaki closed 3 years ago

tomimaki commented 3 years ago

screen0764 screen0765 In this case Setekh, but I saw this on other models like Hecate, Rahu; from BP: Solaris, Erebus (turret debris), Katana, Narayana. Oddly enough, like Hecate, sometimes debris is visible in tech room and briefing popups but not in mission.

Bisected to this:

88c1d8a02a9062c394262aca3888e2debb15c22a is the first bad commit
commit 88c1d8a02a9062c394262aca3888e2debb15c22a
Author: Goober5000 <ipw47@mailbox.org>
Date:   Sat Dec 12 02:04:02 2020 -0500

    consolidate model instance code

 code/ai/aibig.cpp                     |   3 +-
 code/ai/aicode.cpp                    |   5 +-
 code/ai/aiturret.cpp                  |  13 +-
 code/decals/decals.cpp                |  11 +-
 code/hud/hudtarget.cpp                |   1 -
 code/menuui/techmenu.cpp              |  21 +-
 code/mission/missionparse.cpp         |   2 +-
 code/missionui/redalert.cpp           |   2 +-
 code/model/model.h                    |  53 ++---
 code/model/modelanim.cpp              |  54 ++---
 code/model/modelcollide.cpp           |  13 +-
 code/model/modelread.cpp              | 381 ++++++++++++----------------------
 code/model/modelrender.cpp            |  35 +---
 code/network/multi_obj.cpp            |  24 ++-
 code/network/multimsgs.cpp            |  16 +-
 code/object/collideshipship.cpp       |  10 +-
 code/parse/sexp.cpp                   |  40 ++--
 code/scripting/api/objs/subsystem.cpp |  10 +-
 code/ship/ship.cpp                    |  61 +++---
 code/ship/ship.h                      |   4 +-
 code/ship/shipfx.cpp                  |  31 +--
 code/ship/shiphit.cpp                 |   6 +-
 22 files changed, 352 insertions(+), 444 deletions(-)
Goober5000 commented 3 years ago

Can you try bisecting again? That commit doesn't appear to have anything to do with submodel debris.

tomimaki commented 3 years ago

Actually it is not debris, but submodel-destroyed visible all time. And I made mistake, copied commit from another bisection. :( Now it's correct.

Goober5000 commented 3 years ago

Ok. I think I know how to fix this. It's most likely another Volition bug that was uncovered due to the refactoring.

tomimaki commented 3 years ago

Hm, it fixed models in mission and F3 Lab, but not in tech room or briefing popup. screen0007 Hard to show hole in Rahu on screenshot :S

Goober5000 commented 3 years ago

I just checked the Setekh and both the tech room and briefing popup are fixed. So the Rahu must be a different issue. Can you point out exactly what is wrong?

tomimaki commented 3 years ago

https://youtu.be/e6m97YOg0l4 Check Rahu's hm... butt and hole on side and something like z-fighting . Also Cerberus, Watchdog, Alastor have some weird turret configuration. I thought it's the same bug because it showed after bisected commit.

Goober5000 commented 3 years ago

The Rahu thing looks like some sort of graphics issue, not a submodel issue. I would open another ticket for that.

The sentry gun turret thing might be related.