search

scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open
https://www.hard-light.net/
Other
401 stars 161 forks source link

Game version to 21.0 causes gameplay changes #3194

Closed Goober5000 closed 3 years ago

Goober5000 commented 3 years ago

As reported on Discord, MVPs 4.4.0 caused the corvettes in "The Great Hunt" (SM1-06.fs2) to follow their waypoints at a different speed than normal. This was narrowed down to the game version tag in mv_root-mod.tbm...

#GAME SETTINGS
$Target Version:
+Major: 21
+Minor: 0
+Build: 0

mv_root-mod.tbm.txt

As a result, MVPs 4.4.1 do not contain the version tag. But this is actually a bug with the version tag itself. One of the features enabled by the target version is causing the corvettes to change speed when they shouldn't.

To fix this bug it will be necessary to inspect the uses of mod_supports_version in the codebase and see what causing the unintended side effects.

Goober5000 commented 3 years ago

A quick look indicates it might be caused by Fix_ai_class_bug because the corvettes are both assigned the class of Colonel. In that case maybe it isn't actually a bug. Although I would be surprised if different AI classes are intended to follow waypoints at different speeds.

Baezon commented 3 years ago

Fixed by #3195