search

scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open
https://www.hard-light.net/
Other
401 stars 161 forks source link

Discussion: Latin-1 conversion warning for retail tables #4723

Open BMagnu opened 1 year ago

BMagnu commented 1 year ago

Right now, when Unicode Mode is enabled, tables that are found to be encoded in latin1 will automatically be converted to unicode. In doing so, FSO will also throw a warning about this, saying that the tables could contain invalid data. Retails tables were especially problematic, since they had parsing errors manually dealt with in-engine, which wouldn't work in unicode mode. However, these were adapted and fixed with #3263, meaning that while we still want to warn about latin1 user tables, we know that retail tables are safe and will work. Since there are lot of cases where you could just use the retail tables instead of having to copy, fix and then hard-overwrite them, I propose to silence this warning if the table matches the hash of a retail table (notably strings.tbl and weapons.tbl). At the same time, the warning should be rephrased to not talk about "may cause parsing issues with retail FS2 files". Thoughts? Reasons why the warnings should stay for retail files?

Goober5000 commented 1 year ago

This makes sense. I'd be ok with both the warning silencing and the rephrasing.

AdmiralNelsonFSO commented 1 year ago

i would be delighted to have these warnings suppressed.