search

scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open
https://www.hard-light.net/
Other
407 stars 163 forks source link

Missile lead indicator does not show properly on alternate $Lead Indicator Behavior modes. #5088

Closed MoerasGrizzly closed 2 months ago

MoerasGrizzly commented 1 year ago

On the $Lead Indicator Behavior: Average and $Lead Indicator Behavior: Multiple modes, the missile lead indicator displays weirdly.

In a lot of cases it'll only show when your primary weapons are in range, even though you're using, say, a heatseeker missile with a very long range, like the Stiletto.

To test: Set $Lead Indicator Behavior: Average or Multiple in your game settings. Fire up The Sixth Wonder Pick Stiletto missiles for one of your banks. Switch to said missiles.

Notice how the missile lead indicator does not display, even though the Stiletto has a range of 5.5km

MoerasGrizzly commented 1 year ago

Apperently @Kiloku worked on this?

Kiloku commented 1 year ago

I did! Will take a look, thanks

Kiloku commented 1 year ago

Still trying to figure this out. The issue seems to be a bit of an edge case.

It happens while your primaries are linked and all of them are out of range. I can tell that it's related to the "Don't Merge Indicators" code, but I'm having a hard time isolating it in a manner that doesn't break other behavior.

JohnAFernandez commented 10 months ago

I am just updating this issue to say that Kiloku believes that 5094 is insufficient to fix this and that this whole function needs to be rewritten to be clearer. So I'm going to close 5094 as per his request, hoping that one of us will get to reworking that function soon, in order to resolve this bug.

JohnAFernandez commented 2 months ago

Ok, I just sat down, debugged it, and wrote and tested a fix.

If someone were to rewrite the function, they should put the rendering calls at the end of the function, recording what rendering needs to be done based on the mode given.