scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open
https://www.hard-light.net/
Other
402 stars 161 forks source link

Weapons get a purple tint applied to them in the weapon selection screen after this last update #5215

Open wolfestridershooter opened 1 year ago

wolfestridershooter commented 1 year ago

As you can see the maxim cannon is usually white but now it's purple, another example would be on the fins of the tornado missile image

Baezon commented 1 year ago

@qazwsxal or @EatThePath might be able to say more, but I'm pretty sure this is an intentional changes to the tech room to have some slight red and blue accent lights.

EatThePath commented 1 year ago

Historically the tech room, and other views like it such as these these previews has had a single purely white light directly overhead of the object. This is not a good lighting setup, and as assets increasingly include normal maps and PBR materials which depend heavily on lighting to look their best the difference between it and well made level lighting has gotten more and more glaring.

Because of this, and with input from some of the community's more active 3d artists, when the last graphics overhaul went in I also included a revision to this lighting setup as @Baezon said. It is a three light setup, the main light is very slightly orange-yellow, the secondary light is a slightly dimmer light-blue, and the fainter tertiary light is colorless.

image

I'm not sure that fully accounts for the difference you're seeing here, though it'll certainly be part of it.

image

Another likely factor, in the past 3d models have been rendered with a default enviromental map(what you see in the reflections on the shiny surfaces) that is a generic green nebula. I believe the handling of that was changed, which was more @qazwsxal's department than mine so I'm not sure what the exact changes were. But if there is no envmap currently, or the level's envmap is being used, that could make a lot of the difference, as this appears to be an extremely shiny model.

z64555 commented 1 year ago

So... is the tinting working as intended or not?

EatThePath commented 1 year ago

With our hodgepodge of assets and rendering contexts spanning multiple pipeline eras, 'intended' is next to impossible to pin down. But I'll try to get some second opinions on this as soon as is practical.

MjnMixael commented 11 months ago

As the designer of this particular model, I can tell you that is not how it's supposed to look. It's shaded an entirely different color than it used to be.