scp-fs2open / fs2open.github.com

Origin Repository for SCP FreeSpace 2 Open
https://www.hard-light.net/
Other
401 stars 161 forks source link

Crash when saving control config. #6273

Closed Alcom1 closed 3 weeks ago

Alcom1 commented 1 month ago

Crash occurs immediately after saving a control config in the "Control Config" menu.

Before the crash, there were other issues with saving the control config.

Log : https://fsnebula.org/log/66a53c2c25fe9a7d2f0010be

Crash dump: fs2_open_24_0_2_x64_AVX-FASTDBG_20240727_182701.zip

z64555 commented 1 month ago

Do you get the same error when running vanilla FSO? I suspect it may be something on SCPUI's side.

wookieejedi commented 1 month ago

Same, I also concur it's likely SCPUI

JohnAFernandez commented 1 month ago

Here is the stack trace from the minidump. It does seem to be SCPUI related.

Screenshot 2024-08-09 203232

I can't really understand the code fully, but based on this, I'm guessing something caused SCPUI to use up too much stack space?

Screenshot 2024-08-09 203826

This might also be relevant. The variable that keeps track of how much memory was being requested, realsize, either wrapped or is junk memory that the Dump recorded:

Screenshot 2024-08-09 204426

wookieejedi commented 3 weeks ago

This is indeed an SCPUI bug, and a fix has been pushed to SCPUI master here: https://github.com/MjnMixael/SCPUI/issues/13

This can likely be closed as completed

MjnMixael commented 3 weeks ago

Additionally it is now fixed in the next SCPUI version. So it can be doubly closed.

BMagnu commented 3 weeks ago

Right, if it's fixed in SCPUI, closing this issue