search

scp-fs2open / wxLauncher

wxLauncher
Other
26 stars 12 forks source link

long filenames break the basic settings tab #107

Open IssMneur opened 10 years ago

IssMneur commented 10 years ago

From niffiwan...@gmail.com on September 27, 2013 04:01:26

What steps will reproduce the problem?

  1. create this empty file in a new folder: fs2_open_3_6_17_ANTIPODES_r9542_performance_tweaks.patch
  2. create a new wxlauncher profile
  3. in the new profile, select the folder you created in step 1 and notice that the "browse" & "refresh" buttons vanish, meaning if you have "auto save profiles" selected then the profile is permanently broken (short of manually editing the pro?????.ini files)

    What is the expected output? What do you see instead?

I'd expect the browse/refresh buttons to remain, even if an error has been logged

Note the following error was also output to the terminal: ** (wxlauncher:8356): CRITICAL **: clearlooks_style_draw_focus: assertionwidth >= -1' failed`

What version of the wxLauncher are you using: latest trunk/master/tip What version of fs2_open: n/a What mods (and version, if known): n/a What operating system and version: Centos 6, I've seen it reported by at least one other person on IRC Please provide any additional information below. see attached log from running with a Debug version of wxLauncher

Attachment: wxLauncher.log

Original issue: http://code.google.com/p/wxlauncher/issues/detail?id=107

IssMneur commented 10 years ago

From issmn...@gmail.com on September 29, 2013 21:50:08

I have not had a chance to check this yet, but this raises two questions: 1) does it happen if the files name doesn't start with fs2_open? 2) What happens when it is a real executable that that really long name?

Labels: Severity-Low

IssMneur commented 10 years ago

From niffiwan...@gmail.com on September 30, 2013 20:46:12

Thanks for the reply

1) changing the filename to 12345678_3_6_17_ANTIPODES_r9542_performance_tweaks.patch results in wxL not allowing the directory to be selected. i.e. the Browse dialog box reopens when you select "Open". Note that this dir is empty apart from the one file.

2) using this file (fs2_open_3.7.1_DEBUG_r9542_performance_tweaks_123456789012345, 62 chars) you get the originally reported results, except that you can select the exec to run and the assertion doesn't trigger. The Browse button is still missing.

Using this shorter filename (fs2_open_3.7.1_DEBUG_r9542_performance_tweaks, 46 chars) leaves a small part of the Browse & Refresh buttons still visible. The text is missing, but at least you can browse to another dir.

IssMneur commented 10 years ago

From niffiwan...@gmail.com on September 30, 2013 20:50:14

Sorry, should clarify that in option 2 above, its a real exec with a long name.

IssMneur commented 9 years ago

This is still an issue with 0.9.6, though it takes a much longer filename to trigger. The one used in the orignal report is now not long enough. The browse and refresh button of the Basic Settings tab disappears.