search

scp-fs2open / wxLauncher

wxLauncher
Other
26 stars 12 forks source link

ForcePort and CustomIP can't be cleared #98

Closed IssMneur closed 10 years ago

IssMneur commented 10 years ago

From jg18....@gmail.com on December 19, 2012 05:31:58

What steps will reproduce the problem? 1. Start the launcher

  1. Type in values for force local port and force custom IP
  2. Press Play
  3. Exit the game and clear the values for local port and custom IP
  4. Press Play
  5. Exit the game
  6. Check the fs2_open.ini file or registry What is the expected output? What do you see instead? Expected is to see those values for ForcePort and CustomIP removed from the registry. Instead, those values are still there. Please use labels and text to provide additional information. Fixing Issue 97 made this more obvious. Currently, the File/RegistryProfileManager.cpp files only update the registry/ini values for ForcePort and CustomIP if ForcePort is non-zero. More reasonable semantics might be deleting those keys if ForcePort is non-zero and IP addr is blank.

Shouldn't be too hard to fix; just requires some thinking through what should happen in each case if, say, the port is blank but the IP address has a value in it.

Original issue: http://code.google.com/p/wxlauncher/issues/detail?id=98

IssMneur commented 10 years ago

From jg18....@gmail.com on January 07, 2013 08:39:26

Labels: Milestone-Release0.9.4

IssMneur commented 10 years ago

From jg18....@gmail.com on January 28, 2013 02:26:26

This issue was closed by revision c16f8220f79a .

Status: Fixed