search

scp93ch / morse-pro

Library for manipulating Morse code text and sound. Understands prosigns and Farnsworth speed. Can create WAV files and analyse input from the microphone or audio files.
European Union Public License 1.2
118 stars 29 forks source link

dropped dits #1

Closed worsthorse closed 5 years ago

worsthorse commented 6 years ago

when training at speeds greater than 25WPM, the first dit of letters like "r", "l" and "f" is obscured or cut off, so "root" becomes "noot" and "fake" is heard as "rake". the problem is most easily heard when listening to words and is less apparent when playing letter blocks like "r r r r r".

the problem is not apparent at 20WPM or less.

i am guessing that inserting a short delay before playing a string will fix the problem.

thanks! bill K7WXW

scp93ch commented 6 years ago

Thanks for the bug report.

Could you try listening to the same code and speed on my Morse translator? The tools on my website run a slightly more recent version of this library and I think I may have fixed this issue already in the unreleased code.

worsthorse commented 6 years ago

good morning,

i tested it this morning on both firefox (57) and chrome (64). pitch, 600. speed, 25 and 30, farnsworth, 25 and 30. 

it is improved on firefox and works fine on chrome.  on firefox, there is still some sort of glitch, though, that is distorting the first dit. it is not apparent on chrome.

hope this helps.

thanks, bill

From: C Phillips Stephen notifications@github.com Reply: scp93ch/morse-pro reply@reply.github.com Date: February 12, 2018 at 4:29:40 AM To: scp93ch/morse-pro morse-pro@noreply.github.com Cc: K7WXW k7wxw@arrl.net, Author author@noreply.github.com Subject:  Re: [scp93ch/morse-pro] dropped dits (#1)

Thanks for the bug report.

Could you try listening to the same code and speed on my Morse translator? The tools on my website run a slightly more recent version of this library and I think I may have fixed this issue already in the unreleased code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

scp93ch commented 6 years ago

Thanks, that's useful. I'll make a note to at least make a configurable pause at the start.

cniesen commented 6 years ago

The configurable pause would be really nice. I'm experience a dropped dit at random times using chrome and firefox on an android phone when working with the trainer

scp93ch commented 5 years ago

I've just uploaded v2.0.0 which has a configurable initial pause in the generated waveform. I believe this should solve your problem.

scp93ch commented 5 years ago

@cniesen are you able to check that your problem is solved? Then I can close this issue. Thanks.

cniesen commented 5 years ago

Sounds great on my Samsung Galaxy S6 (Android 7), a LG K20 Plus (Android 7), and Motorola Moto e5 Plus (Android 8). But dits are missing on my Galaxy S4 (Android 5.0.1).

Video of S4 https://youtu.be/KsgqVjGXHFY

Tested always with the stock chrome browser.

scp93ch commented 5 years ago

Thanks for the tests.

I think that I have fixed the issue in this morse-pro library but that I need to expose the configurable start-up delay in the interface of the tools on my website. At the moment they use a hard-coded 50ms delay if I remember correctly.

I'll close this issue as the issue on morse-pro itself is fixed.

I'll add the configurable start-up delay to a private issue tracker I have for the website.