scpike / rails-units

Unit conversion class for rails based on ruby-units
MIT License
7 stars 1 forks source link

Duplicated keys #2

Open garysweaver opened 9 years ago

garysweaver commented 9 years ago

See: https://github.com/garysweaver/rails-units/commit/20913bc1b887a20a060110d02b6d46f1d8431b2c

Not suggesting the changes in that fork since they may affect typographers, since am deferring to length over typography values, but this is just a notice that there are duplicate keys.

diff --git a/lib/rails_units/unit_definitions.rb b/lib/rails_units/unit_definitions.rb
index 775e299..29eeff5 100644
--- a/lib/rails_units/unit_definitions.rb
+++ b/lib/rails_units/unit_definitions.rb
@@ -117,7 +117,7 @@ UNIT_DEFINITIONS = {
   '<mmHg>' => [%w{mmHg}, 133.322368,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
   '<inHg>' => [%w{inHg}, 3386.3881472,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
   '<torr>' => [%w{torr}, 133.322368,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
-  '<bar>' => [%w{bar}, 100000,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
+  #'<bar>' => [%w{bar}, 100000,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
   '<atm>' => [%w{atm ATM atmosphere atmospheres}, 101325,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
   '<psi>' => [%w{psi}, 6894.76,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
   '<cmh2o>' => [%w{cmH2O}, 98.0638,:pressure, %w{<kilogram>},%w{<meter> <second> <second>}],
@@ -226,8 +226,8 @@ UNIT_DEFINITIONS = {
   '<pixel>' => [%w{pixel px}, 1, :resolution, %w{<each>}],
   '<ppi>' => [%w{ppi}, 1, :resolution, %w{<pixel>}, %w{<inch>}],
   '<dpi>' => [%w{dpi}, 1, :typography, %w{<dot>}, %w{<inch>}],
-  '<pica>' => [%w{pica}, 0.00423333333 , :typography, %w{<meter>}],
-  '<point>' => [%w{point pt}, 0.000352777778, :typography, %w{<meter>}],
+  #'<pica>' => [%w{pica}, 0.00423333333 , :typography, %w{<meter>}],
+  #'<point>' => [%w{point pt}, 0.000352777778, :typography, %w{<meter>}],
scpike commented 9 years ago

Thanks for pointing this out!