scragg0x / realms-wiki

Git based wiki inspired by Gollum
http://realms.io
GNU General Public License v2.0
833 stars 91 forks source link

Let config instance be readable like a dict #156

Closed gazpachoking closed 7 years ago

gazpachoking commented 7 years ago

For options that don't have defaults included in the main Config class, I think conf.get('THEOPTION') is a nicer way to use the config than getattr(conf, 'THEOPTION', None). Now that I've typed out that reasoning, I'm wondering if just adding a get method is better than the full Mapping interface.

gazpachoking commented 7 years ago

I guess config is mostly accessed through app.config. This is maybe not so important.