search

scragg0x / realms-wiki

Git based wiki inspired by Gollum
http://realms.io
GNU General Public License v2.0
833 stars 91 forks source link

Remove gittle dependency and use dulwich directly #158

Closed gazpachoking closed 7 years ago

gazpachoking commented 7 years ago

Gittle isn't documented very well, doesn't seem complete, and has dulwich pinned to an old version. I think we should ditch it in favor of using dulwich directly. I believe this PR is complete, and it ends up removing more code than it adds.

EDIT: Bonus: wiki pages inside subdirectories work on Windows now.

gazpachoking commented 7 years ago

@scragg0x Any opinion on this? (or any of my other PRs :wink:)

gazpachoking commented 7 years ago

Finding out pages in subdirectories were only broken on Windows because of gittle pushed me over the edge on this. Pulling the trigger. @scragg0x Some feedback on some of the stuff I've done/plan to merge/should undo would be appreciated if you get time. I get more unsure of myself the more I merge without feedback.

scragg0x commented 7 years ago

@gazpachoking The PR is good. Sorry for not getting back to you sooner. Thanks for the help.