search

scragg0x / realms-wiki

Git based wiki inspired by Gollum
http://realms.io
GNU General Public License v2.0
831 stars 90 forks source link

Relative links #18

Closed bdillahu closed 9 years ago

bdillahu commented 9 years ago

Do relative links (i.e. no http and domain - test ) not work, or am I don't something wrong?

Was trying to not have to have the full domain, etc. in all the links.

Thanks! Bruce

scragg0x commented 9 years ago

I noticed that, I am going to look into it.

scragg0x commented 9 years ago

Can you give an example on how to reproduce this bug.

bdillahu commented 9 years ago

Just have a link in your text, such as:

[test](test.md)

and it recognizes the link, but doesn't work when you click it.

[test](http://testdomain.com/test.md)

Will work (assuming the domain, etc. is right.

scragg0x commented 9 years ago

Ok I see. I think [test](/test.md) works but still not a relative link but better. It's the marked.js lib that is parsing the Markdown. It looks like they have an open issue on it here: https://github.com/chjj/marked/issues/320

scragg0x commented 9 years ago

nevermind, I found it. The markdown renderer had sanitize mode enabled. Not only that, it was a bit overzealous with urls. The idea was to enable sanitize while collaborating only.

bdillahu commented 9 years ago

Thanks!