search

scragg0x / realms-wiki

Git based wiki inspired by Gollum
http://realms.io
GNU General Public License v2.0
833 stars 91 forks source link

python3 porting status #219

Open jelmer opened 6 years ago

jelmer commented 6 years ago

The README mentions that Python3 support is a work in progress; is there a more detailed status description somewhere? What is left to do?

scragg0x commented 6 years ago

@jelmer I'm not sure what else needs to be done. I have not been actively developing realms lately and maintainers are welcome.

jelmer commented 6 years ago

I might contribute a patch or two if I find issues :)

I was also considering packaging realms for Debian, but that may not be the greatest idea if the project is in a dormant state.

scragg0x commented 6 years ago

PRs welcome, just keep in mind any breaking changes.

I think a deb is a good idea. Ideally realms would be much easier to setup if there existed a deb w/ ppa. I think first the code needs to be stable, secure, and existing features completed.

jelmer commented 6 years ago

It fails pretty early for me; i.e. reload isn't available in python3 and used in the third line or so of realms/init.py.

gazpachoking commented 6 years ago

Hmm, that whole bit with setting sys.setdefaultencoding seems dubious to me. Is that just to avoid explicit utf-8 decoding of bytes in other locations? Is the calling of reload just to detect python 3?

scragg0x commented 6 years ago

That bit should be removed, it was added awhile back in an attempt to fix encoding when printing to the console... The reload is there as a hack to bring the attribute back so it can be set.

gazpachoking commented 6 years ago

Do you know if there is any code relying on that still? I agree it would be nice to remove it, for more than just supporting python 3 reasons.

jelmer commented 6 years ago

FWIW I've packaged the missing (Python3) dependencies for realms-wiki in Debian unstable. They should make it out to Ubuntu in a few months.

(Note that Debian no longer accepts new Python2 packages)