search

scragg0x / realms-wiki

Git based wiki inspired by Gollum
http://realms.io
GNU General Public License v2.0
833 stars 90 forks source link

Question about encode format #59

Closed magic890 closed 9 years ago

magic890 commented 9 years ago

I'm wondering why you are using latin-1 encode on https://github.com/scragg0x/realms-wiki/blame/master/realms/modules/wiki/models.py#L180-L181 or https://github.com/scragg0x/realms-wiki/blob/master/realms/modules/wiki/models.py#L66 instead of UTF8.

I know that it is smaller for store data, but it is not so wider in character encoding as UTF8.

There is any particular reason?

scragg0x commented 9 years ago

UTF-8 should be fine assuming gittle is ok with it. In this case, it shouldn't matter because one is a sha1 and other is filename which is restricted to match a URL friendly name (the canonical name).

magic890 commented 9 years ago

Thank you for the clarification.