gittle.rm not working - Githubissues

scragg0x / realms-wiki

Git based wiki inspired by Gollum

http://realms.io

GNU General Public License v2.0

831 stars 90 forks source link

Closed magic890 closed 8 years ago

magic890 commented 9 years ago

It seems that gittle.rm() is not working. See this lines:

After that command, in the commit there isn't the removed file and the file persist on file system.

Do you know why this is not working and how to solve this issue?

scragg0x commented 9 years ago

Can you confirm that the web app has permission to remove the file? It's possible it only has permissions to the .git dir.

magic890 commented 9 years ago

The wiki and wiki/.git directories have 755. The files have 644.

I tried also to change files permission to 777, without success.

scragg0x commented 9 years ago

@magic890

It's possible I have never tried to delete a page via gittle. Did you manage to get it working?

magic890 commented 9 years ago

I'm working on it, using this repo. When it'll work I'll suggest a PR.

alvinchow86 commented 9 years ago

I noticed this problem as well. I think the problem is that at https://github.com/scragg0x/realms-wiki/blob/master/realms/modules/wiki/models.py#L106; I added some debug statements and noticed that old_name and new_name are the same . This is called from https://github.com/scragg0x/realms-wiki/blob/master/realms/modules/wiki/models.py#L106

alvinchow86 commented 9 years ago

gazpachoking commented 8 years ago

Believe this is fixed now.