Implement delete page - Githubissues

alvinchow86 commented 8 years ago

Hook up the "Delete Page" button and get it working.

gittle.rm() only touches the index, seems like we actually have to remove the file ourselves..
added some simple JS that prompts the user, and adds a confirmation after successful delete
apparently gittle.rm() (or rather dulinger) doesn't take unicode input, had to make sure its UTF8
fixed the test_delete_page test, it wasn't actually really testing anything because no page was created. (before my fix it fails, but passes after)
upgraded gittle to 0.5.0, why not

More than happy to make any tweaks or style fixes if needed

scragg0x commented 8 years ago

Very nice thanks!

alvinchow86 commented 8 years ago

Thanks! BTW there was one more commit in the other branch https://github.com/scragg0x/realms-wiki/pull/81, https://github.com/doordash/realms-wiki/commit/b517e7e71441a5d9c1414e1774c060712920d5df, that we may want to get in. It fixes a bug with rename page, where every edit did a "Rename/Move" operation (if your page name has upper case letters)

scragg0x commented 8 years ago

Oh thanks, I just saw that. I should start at the bottom of the list.

alvinchow86 commented 8 years ago

One more improvement idea - it might be less obtrusive to avoid the second "delete confirmation popup" and do a flashmessage instead or something

scragg0x commented 8 years ago

I agree

scragg0x / realms-wiki