search

scraly / developers-conferences-agenda

This repository list a maximum of tech conferences's date and CFP in order to help conferences organizers, speakers & attendees
https://developers.events/
1.61k stars 393 forks source link

feat: New Filter UI (No new list view commits) #1063

Closed HanzCEO closed 3 months ago

HanzCEO commented 3 months ago

Cherry picked

scraly commented 3 months ago

It's OK for me, just one thing.

I tested on small screen and it's a little buggy in "list" view:

image

The 3 icons at the right are not displayed, only the first.

HanzCEO commented 3 months ago

It should fix it

scraly commented 3 months ago

Thanks, it sounds better :) Can you rebase in order to pull the latest events? :) And then I will merge it.

scraly commented 3 months ago

There is one behavior that is strange to me. In the current version, I can change the filter and watch the events listed, and change the filter again:

image

In your version, I can't see all the events listed:

image

The events are truncated. Is it possible to have the same behavior?

HanzCEO commented 3 months ago

@scraly, I will stand on my ground to keep my changes because of performance reason. There is a lot of people who doesn't run their browser with smooth graphics card or display. However, it is possible if someone were to structurally change the Filter component placement. Right now, I just see it as a technical debt for not placing the filter in the right place.

scraly commented 3 months ago

OK that's ok for me :)