search

scramjetorg / scramjet

Public tracker for Scramjet Cloud Platform, a platform that bring data from many environments together.
https://www.scramjet.org
MIT License
253 stars 20 forks source link

DataStreamOptions.objectMode causes compilation failure #97

Closed skif48 closed 3 years ago

skif48 commented 3 years ago

screenshot-2020-12-03T16:42:40 Hi! I found a weird thing in types of this project.

Basics DataStreamOptions interface. "objectMode" property.

Describe the bug "objectMode" property is duplicated, which fails the compilation step.

To Reproduce Just install scramjet@4.35.7 on a typescript project and try to compile it.

Expected behavior No compilation error.

Test case Just install scramjet@4.35.7 on a typescript project and try to compile it.

System:

Additional context: https://github.com/signicode/scramjet/blob/master/.d.ts/index.d.ts#L980 https://github.com/signicode/scramjet/blob/master/.d.ts/index.d.ts#L992

Duplicated "objectMode" property seems to be added in this commit: https://github.com/signicode/scramjet/commit/5217af78632d758e1d49b774001f34efeecff6e7

Hope you can help, thanks!

Edit: attached a screenshot.

MichalCz commented 3 years ago

Thanks for the info. We'll fix this before Monday.

M.

MichalCz commented 3 years ago

And fix released - please reopen if you still experience any issues.

skif48 commented 3 years ago

Hi @MichalCz !

Confirming, works now. Appreciate your help and quick resolution.

MichalCz commented 3 years ago

Well paraphrasing Monty Python... it's all in the days work for scramjet repair man. ;D