scramjetorg / transform-hub

Scramjet Transform Hub (STH) is a runtime supervisor that can run data processing programs called Sequences and manage local resources on any Linux server, Docker on small edge servers, and even large-scale Kubernetes clusters in the cloud or datacenters. It connects to Scramjet Spaces in Scramjet Cloud Platform.
GNU Affero General Public License v3.0
67 stars 8 forks source link

Set default runner envs with `--runner-envs` STH param #986

Closed piotrek6641 closed 1 year ago

piotrek6641 commented 1 year ago

Added option to start declare env variablers when starting sth

Example:

DEVELOPMENT=1 yarn start:dev --runner-envs "KEY1=VALUE1;KEY2=VALUE2"

Only acceptable format is providing variables in a key:value format with a space between them. Otherwise error will be thrown

Clickup Task: https://app.clickup.com/t/24308805/VDM-1268

patuwwy commented 1 year ago

Please consider my suggestion from clickup task

alicja-gruzdz commented 1 year ago

excellent, thanks @piotrek6641 I have only one comment about naming. Option -e maybe confused with -E (--identify-existing). Perhaps we should leave only --runner-envs option. Unless you have an idea how to change these naming to differentiate between them - ?

alicja-gruzdz commented 1 year ago

Verify: Screenshot from 2023-11-27 12-14-30 Seems to work nicely, thanks!