search

scrapd / scrapdviz

Visualize Austin traffic fatalities from another angle
https://viz.scrapd.org
MIT License
1 stars 10 forks source link

Misc. fixes for Hero Image #186

Closed ghost closed 4 years ago

ghost commented 5 years ago

Issue Type

Current Behavior

Currently at a mobile screen dimension, the hero image is:

No credit given for image, found here

Expected Behavior

Hero image should be responsive, proper display on mobile screen dimensions.

Credits should be provided for image.

Possible Solution

Media queries with Emotion should address this. Documentation here.

Steps to Reproduce

  1. Open home page
  2. Resize screen width to under a width of 750px or under.

Context

The hero image is unsightly for users on mobile devices.

ghost commented 4 years ago

Working on in forked repo.

ghost commented 4 years ago

Work on this issue is complete! I believe the last time, there was another branch on the project (not master) to which I made pull requests...am I remembering that right?

Also I just happened to have some time this break to work on this, this can wait til after the break/January.

rgreinho commented 4 years ago

You are remembering correctly. But it was because we were working on a series of big changes so we created a long term branch where we could potentially mess up things without affecting master and production.

Now you can safely base your work on master.

rgreinho commented 4 years ago

https://www.responsivebreakpoints.com/ generates responsive images, provides all the sizes and HTML5 snippets to include in the code.