Scrapd3/186 - Githubissues

scrapd / scrapdviz

Visualize Austin traffic fatalities from another angle

https://viz.scrapd.org

MIT License

1 stars 10 forks source link

Scrapd3/186 #200

Closed ghost closed 4 years ago

ghost commented 4 years ago

Types of changes

Bug fix (non-breaking change which fixes an issue)

Description

Makes Hero Image responsive Adds photo credit

Providesfor a better experience on non-desktop screen dimensions

Runs as expected, locally.

Checklist

[] I have updated the documentation accordingly
[] I have written unit tests

Fixes scrapd/scrapdviz#186

ghost commented 4 years ago

This PR does not utilize Response Breakpoints mentioned in the Issue, but it works fine. Let me know if you'd like that site's tech to have been utilized.

ghost commented 4 years ago

Done, and ready for review.

I'm not happy with how "Visualizing the data" looks on mobile at some dimensions. But this could be good for now? I can get on it if you want me to polish that.

rgreinho commented 4 years ago

Love it!

Yep, you could work on "Visualizing the data" looks on mobile in another PR, no worries.