search

scraperwiki / code-scraper-in-browser-tool

Just like on ScraperWiki Classic; now a part of QuickCode.
https://quickcode.io
Other
38 stars 8 forks source link

PHP Code too dark to read without lots of squinting #101

Closed mikeschinkel closed 11 years ago

mikeschinkel commented 11 years ago

I just tried ScraperWiki which I learned about from Kin Lane's post but the PHP code is too dark to read without headache-inducing squinting and I could not find any why to modify the colors used for syntax highlighting.

zarino commented 11 years ago

The code you're talking about is inside a comment. PHP comments look like this:

/*

This is a comment.

*/

You'll notice the text outside the comments is bright white.

Try removing the /* */ lines, or putting code before or after them.

mikeschinkel commented 11 years ago

Hi @zarino - Good point. Feeling kinda silly right now. And it's not like I haven't been professionally programming in PHP for 5+ years. Doh! :)

Still, while we are here, even the comments are a bit dark?

frabcus commented 11 years ago

It's using this theme:

editor.setTheme("ace/theme/monokai")

(see https://github.com/frabcus/code-scraper-in-browser-tool/blob/master/http/code.js)

You can SSH into one of your code in browser tools, and edit tool/http/code.js to change it if you like!

Or, perhaps worth filing a bug in the ACE editor with that theme?

mikeschinkel commented 11 years ago

@frabcus - Gotcha, thanks.

You can SSH into one of your code in browser tools, and edit tool/http/code.js to change it if you like!

For that I would not begin to know how.

Or, perhaps worth filing a bug in the ACE editor with that theme?

Maybe. I just tried ScraperWiki today; I'll see if I find a real need for it in the future and if so will probably follow up.

frabcus commented 11 years ago

@mikeschinkel ok!