search

scraperwiki / scraperwiki-php

Non-packaged PHP libraries that ScraperWiki Classic uses
4 stars 5 forks source link

There was bug with some excel files. Sometimes number 1 becames 1.11, #5

Closed OlegTar closed 9 years ago

OlegTar commented 9 years ago

number 2 becames 2.22, 10 becames 10.1010. Now it's fixed.

pwaller commented 9 years ago

Hi @OlegTar! Thanks for contributing.

I'm reluctant to accept this since it is to a library we didn't develop, which means that if we ever update that in the future, your fix will be undone. It seems that php-excel-reader also looks defunct. In addition, we don't have anyone here who regularly uses or understands this library and it has few users. If your change happens to introduce a bug for someone else it may be very hard for us to track it down. There is also little information here about what this fixes, for example an example to reproduce the problem.

Can you consider just taking this fix in your local copy? I'm sorry I don't have a better suggestion than that at this point. I hope you can understand.

OlegTar commented 9 years ago

I understand you