search

scraperwiki / spreadsheet-download-tool

A ScraperWiki plugin for downloading data from a box as a CSV or Excel spreadsheet
BSD 2-Clause "Simplified" License
2 stars 1 forks source link

Spreadsheet download tool creates invalid XLSX files from SQL tables #57

Closed zarino closed 10 years ago

zarino commented 10 years ago

The latest iteration of the Spreadsheet Download tool generates XLSX files fine from "grids" (ie: unstructured HTML tables generated by the Extract Tables tool), but when you run it on a dataset with normal SQL tables, you get a series of errors:

Excel on Windows 7:

image

image

Excel 2011 on OS X:

screen shot 2013-11-20 at 10 40 04

screen shot 2013-11-20 at 10 40 12

screen shot 2013-11-20 at 10 40 42

Excel "repairs" the document by deleting all the sheets inside it. Which is pretty useless.

pwaller commented 10 years ago

Suspicion: Can you try renaming it to xls?

zarino commented 10 years ago

@pwaller: Renaming to xls makes no difference. The same error message comes up.

(aside: so it seems Excel is clever enough to detect an OOXML file even if it doesn't have the right extension. Fancy that.)

morty commented 10 years ago

Forgot to link my pull request to this issue.

https://github.com/scraperwiki/spreadsheet-download-tool/pull/58

pwaller commented 10 years ago

:+1: on the quick fox @morty, though it wasn't clear that your fix was related to this or that you were working on it.

zarino commented 10 years ago

:+1: on the quick fox @morty

The quick brown fox jumps over the lazy dog ;-)

zarino commented 10 years ago

The fix for this has been deployed to all existing Spreadsheet Download instances.