scraperwiki / stock-tool

ScraperWiki stock ticker tool
Other
0 stars 1 forks source link

Consider installing dshelpers on boxes to remove need for requirements install #13

Closed StevenMaude closed 10 years ago

StevenMaude commented 10 years ago

There are bits of JavaScript and a shell script to install requirements if necessary, and to check if they are installed every time the get symbols button is pressed (see #2). These could be removed entirely if dshelpers is installed on the platform. dshelpers is the only dependency that's actually installed with pip; the other requirements are already present.

This would (slightly) speed up the process of getting the list of tickers, and allow some pruning of the code.

frabcus commented 10 years ago

Yeah, I'm generally in favour of as much as possible being in basejail.

Others disagree!

On Tue, May 13, 2014 at 08:08:36AM -0700, Steven Maude wrote:

There are bits of JavaScript and a shell script to install requirements if necessary, and to check if they are installed every time the get symbols button is pressed (see #2). These could be removed entirely if dshelpers is installed on the platform. dshelpers is the only dependency that's actually installed with pip; the other requirements are already present.

This would (slightly) speed up the process of getting the list of tickers, and allow some pruning of the code.


Reply to this email directly or view it on GitHub: https://github.com/scraperwiki/stock-tool/issues/13

pwaller commented 10 years ago

I think actually most are in favour of it these days?

StevenMaude commented 10 years ago

See #14.

StevenMaude commented 10 years ago

Closed as #14 now merged.