search

scrapinghub / dateparser

python parser for human readable dates
BSD 3-Clause "New" or "Revised" License
2.56k stars 465 forks source link

Add 'ago' to french relative parsing #1110

Closed gutsytechster closed 1 year ago

gutsytechster commented 1 year ago

This fixes #1102

wRAR commented 1 year ago

Does French really use the English word "ago" in the same way English uses it? I can't find anything that proves it.

serhii73 commented 1 year ago

Looks like you're right @wRAR Can you please check @gutsytechster this link: https://www.interglot.com/dictionary/fr/fr/translate/il%20y%20a Thanks in advance.

gutsytechster commented 1 year ago

I understood from the initial issue that the English word ago is used along with the French word. I also checked the dictionary with @serhii73 mentioned in the above message, and I don't see any french word ago in that. So it shouldn't have any other meaning besides the English meaning.

serhii73 commented 1 year ago

I guess it makes sence just add a test for:

from dateparser import parse

parse('4 heures ago')

>> None

And don't add ago to French. What do you think, guys?

wRAR commented 1 year ago

Yeah.